Prevent reconfiguration causing exception #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into a problem with a configuration using both the firebasex and firebase-analytics plugins. The latter was doing "[FIRApp configure]" during the "[self application:application..." super call at the top of this function, which caused an exception when FIRApp was configured again by this plugin. The exception bypassed the remainder of the code block and prevented our app from receiving push notification data.
|
I wonder if there's a similar issue on Android? The plugin calls https://firebase.google.com/docs/reference/android/com/google/firebase/FirebaseApp |
dpa99c
pushed a commit
that referenced
this pull request
Jun 8, 2020
dpa99c
pushed a commit
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a problem with a configuration using the firebasex and firebase-analytics plugins together. The latter was performing
[FIRApp configure]during the[self application:application...super call at the top of this function, which caused an exception when FIRApp was configured again by this plugin. This exception bypassed the remainder of the code block and prevented our app from receiving push notification data when the terminated (not just backgrounded) iOS app was opened by tapping a notification.PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
Reconfiguration of FIRApp causes an exception in
appWasConfiguredTwice. Another plugin (firebase-analytics) was configuring FIRapp already, so this simply makes configuration conditional on![FIRApp defaultApp].Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
Without this change, the exception is raised and data from a tapped push notification received when the app is terminated does not reach our code. With the change, all notifications work as expected.
What testing has been done on existing functionality?
Our app works as expected now.
Other information
Sorry, I forgot to make a branch and just made the change directly in the master of my fork. Let me know if that's a problem and I can resubmit. It's really a one-line logic change with some whitespace implications. Thanks for all your great work!